Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteConnection id not unique #766

Open
ue71603 opened this issue Apr 13, 2021 · 2 comments
Open

SiteConnection id not unique #766

ue71603 opened this issue Apr 13, 2021 · 2 comments

Comments

@ue71603
Copy link

ue71603 commented Apr 13, 2021

The ID of SiteConnection is built from the two relevant StopPlaces. However, it is possible to have multiple Connections between two StopPlaces (as it seems). This may be a problem in the GTFS, but it results in an id conflict in the resulting. Or some information was lost. In any case in the resulting correspondances.xml file, there should only be one SiteConnection element with a given id.

				<SiteConnection id="FR:SiteConnection:8100042_8100042:" version="any">
					<WalkTransferDuration>
						<DefaultDuration>PT1800S</DefaultDuration>
					</WalkTransferDuration>
					<From>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</From>
					<To>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</To>
				</SiteConnection>
				<SiteConnection id="FR:SiteConnection:8100042_8100042:" version="any">
					<WalkTransferDuration>
						<DefaultDuration>PT1800S</DefaultDuration>
					</WalkTransferDuration>
					<From>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</From>
					<To>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</To>
				</SiteConnection>
				<SiteConnection id="FR:SiteConnection:8100042_8100042:" version="any">
					<WalkTransferDuration>
						<DefaultDuration>PT1800S</DefaultDuration>
					</WalkTransferDuration>
					<From>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</From>
					<To>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</To>
				</SiteConnection>
				<SiteConnection id="FR:SiteConnection:8100042_8100042:" version="any">
					<WalkTransferDuration>
						<DefaultDuration>PT1800S</DefaultDuration>
					</WalkTransferDuration>
					<From>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</From>
					<To>
						<StopPlaceRef ref="FR:StopPlace:Navitia_8100042:">
						</StopPlaceRef>
						<QuayRef ref="FR:Quay:8100042:">
						</QuayRef>
					</To>
				</SiteConnection>

We used https://data.oebb.at/oebb?dataset=uddi:cd36722f-1b9a-11e8-8087-b71b4f81793a for the transform

@woshilapin
Copy link
Contributor

woshilapin commented Apr 13, 2021

(note: I edited your comment to improve the rendering of the XML extract you provided)

This looks like a bug to me. Even if the origin GTFS have duplicated transfers rules (which seems possible from the specification, but probably is dubious), we might be able to remove the duplicate rules when we generate the SiteConnection. Not sure if we'll be able to fix that quickly though.

@ue71603
Copy link
Author

ue71603 commented Apr 13, 2021

No problem there. We are not in a hurry. :-) It might be that in the original data there was more data for the transfers (e.g. platforms) that was omitted when writing to GTFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants