Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: ShopifyImg component migrated to .vue from .ts (#170) #172

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

sanskar345
Copy link
Contributor

Closes #170

Description:

  • Created Shopify Img component with composition API style and deleted ShopifyImg.ts

Steps to verify:

  • Proper working of ShopifyImg component in apps.
  • Image size changes when passing size by props in the component

@sanskar345 sanskar345 changed the title Improved: ShopifyImg component now created with Vue composition API style (#170) Improved: ShopifyImg component migrated to .vue from .ts (#170) Sep 19, 2023
@ravilodhi ravilodhi merged commit 444d762 into hotwax:main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Shopify Image Component Using Vue
4 participants