Implemented: centralized facility switcher to be used in all app (#138) #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
suggested changes
Sep 15, 2023
alsoK2maan
suggested changes
Sep 19, 2023
alsoK2maan
suggested changes
Sep 21, 2023
ymaheshwari1
requested changes
Oct 3, 2023
package-lock.json
Outdated
| @@ -8306,4 +8306,4 @@ | |||
| "dev": true | |||
| } | |||
| } | |||
| } | |||
| } | |||
src/components/FacilitySwitcher.vue
Outdated
|
|
||
| if(currentUserAppState.currentFacility.facilityId && currentUserAppState.currentFacility.facilityId != selectedFacility && currentUserAppState.userProfile?.facilities) { | ||
| // Below check is a handle case for the inventory-count app. | ||
| if(appState.uploadProducts && Object.keys(appState.uploadProducts).length > 0 ) { |
There was a problem hiding this comment.
We should remove the app specific support from dxp.
amansinghbais
changed the title
1 task
amansinghbais
changed the title
alsoK2maan
suggested changes
Oct 9, 2023
src/components/FacilitySwitcher.vue
Outdated
| @@ -0,0 +1,61 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Rename the component to DxpFacilitySwticher
alsoK2maan
suggested changes
Oct 10, 2023
| import { appContext } from '../index'; | ||
| import { computed } from 'vue'; | ||
|
|
||
| const emit = defineEmits(['check-facility', 'update-facility']) |
There was a problem hiding this comment.
We can update the emit names to before-set-facility and after-set-facility for more readability.
| } | ||
| }); | ||
|
|
||
| const setFacility = async (event: any) => { |
There was a problem hiding this comment.
Suggested change
| const setFacility = async (event: any) => { | |
| const setFacility = async (event: CustomEvent) => { |
| const currentUserAppState = JSON.parse(JSON.stringify(userAppState.value)) | ||
| const selectedFacility = event['detail'].value | ||
|
|
||
| if(currentUserAppState.currentFacility.facilityId && currentUserAppState.currentFacility.facilityId != selectedFacility && currentUserAppState.userProfile?.facilities) { |
There was a problem hiding this comment.
Suggested change
| if(currentUserAppState.currentFacility.facilityId && currentUserAppState.currentFacility.facilityId != selectedFacility && currentUserAppState.userProfile?.facilities) { | |
| if(currentUserAppState.currentFacility.facilityId !== selectedFacility && currentUserAppState.userProfile?.facilities) { |
alsoK2maan
suggested changes
Oct 10, 2023
| emit('check-facility', selectedFacility) | ||
|
|
||
| await appState.dispatch('user/setFacility', { | ||
| 'facility': currentUserAppState.userProfile.facilities.find((facility: any) => facility.facilityId == selectedFacility) |
There was a problem hiding this comment.
While implementing in apps, check if this is done in the actions already, and remove it if so.
alsoK2maan
suggested changes
Oct 12, 2023
| return { | ||
| currentFacility: appState.getters['user/getCurrentFacility'], | ||
| userProfile: appState.getters['user/getUserProfile'], | ||
| uploadProducts: appState.getters['product/getUploadProducts'] |
Comment on lines
37
to
43
| const userAppState = computed(() => { | ||
| return { | ||
| currentFacility: appState.getters['user/getCurrentFacility'], | ||
| userProfile: appState.getters['user/getUserProfile'], | ||
| uploadProducts: appState.getters['product/getUploadProducts'] | ||
| } | ||
| }); |
|
|
||
| const setFacility = async (event: CustomEvent) => { | ||
| const currentUserAppState = JSON.parse(JSON.stringify(userAppState.value)) | ||
| const selectedFacility = event.detail.value |
There was a problem hiding this comment.
Suggested change
| const selectedFacility = event.detail.value | |
| const facilityId = event.detail.value |
alsoK2maan
approved these changes
Oct 12, 2023
|
Closing as handled in #320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: #138
Short Description and Why It's Useful
Implemented centralized facility switcher component of the settings app in dxp-components so that it can be used in any of the app.
Steps to verify
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance