Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable data extracts via YAML config, so user can define which linear feature type to split on #39

Open
Sujanadh opened this issue Jul 8, 2024 · 1 comment
Assignees
Labels
effort:medium Likely a day or two enhancement New feature or request priority:low Backlog of tasks that will be addressed in time

Comments

@Sujanadh
Copy link
Contributor

Sujanadh commented Jul 8, 2024

Is your feature request related to a problem? Please describe.
Currently, we are filtering data extracts in the fmtm-splitter algorithm by hardcoding tags, for example, highways (residential, pedestrian, track), which sometimes creates irrelevant splits.

Describe the solution you'd like
This filtering should be done when extracting data from OSM instead of filtering after the data is extracted.

Describe alternatives you've considered
An alternative approach can be creating a dynamic yaml config file like we do for dynamic xls form edit in fmtm so that users can filter tags themselves based on their desired splitted task response. This can be done on a platform like FMTM so that the algorithm doesn't have to rely on the hardcoded filters.

Additional context
Add any other context or screenshots about the feature request here.

@spwoodcock
Copy link
Member

spwoodcock commented Jul 8, 2024

For context: before splitting the provided features, we first download a data extract of linear features (major roads, rivers, etc). This is used to divide the features by. By default we use major highways, waterways, aeroways, railways.

It's a good idea to allow the type of selected linear features to be configurable 👍

If we provide a default, but allow an override this would be best.

The standard FMTM user wouldn't necessarily need full control of the configuration, but to make it easier we could probably provide them some presets (such as major / minor roads)

@manjitapandey manjitapandey added the enhancement New feature or request label Jul 9, 2024
@spwoodcock spwoodcock changed the title Filter data extracts in yaml config Configurable data extracts via YAML config, so user can define which linear feature type to split on Oct 29, 2024
@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time effort:medium Likely a day or two labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Likely a day or two enhancement New feature or request priority:low Backlog of tasks that will be addressed in time
Projects
None yet
Development

No branches or pull requests

3 participants