Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI markdown checking #146

Open
ThomDietrich opened this issue Nov 29, 2018 · 5 comments
Open

TravisCI markdown checking #146

ThomDietrich opened this issue Nov 29, 2018 · 5 comments

Comments

@ThomDietrich
Copy link
Collaborator

How about adding a markdown style check to the CI chain?

I've defined a good remark-lint rule set here: https://github.com/openhab/openhab-docs/blob/gh-pages/package.json

@davidgraeff
Copy link
Member

The CI chain on the website end is go and python. Do we really want to introduce a javascript chain as well? (Especially with all those horror messages about npm malware currently in the media)

@ThomDietrich
Copy link
Collaborator Author

ThomDietrich commented Nov 30, 2018

Don't know why not. It will only be executed within the isolated environment of TravisCI!?
Besides, in terms of testing I believe that a consistent markdown style in the convention and all PRs should be of importance and is worth including in an automated way.

@davidgraeff
Copy link
Member

Ok, I'm fine with it

@mjcumming
Copy link
Contributor

@ThomDietrich can this be closed?

@davidgraeff
Copy link
Member

The MR is not yet there, is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants