Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure data is only transmitted on open and ready connections. #1051

Merged
merged 3 commits into from
Jul 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib/camera/RecordingManagement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,10 @@ class CameraRecordingStream extends EventEmitter implements DataStreamProtocolHa
let offset = 0;
let dataChunkSequenceNumber = 1;
while (offset < fragment.length) {
if (this.closed) {
break;
}

const data = fragment.slice(offset, offset + maxChunk);
offset += data.length;

Expand Down
4 changes: 3 additions & 1 deletion src/lib/datastream/DataStreamServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,9 @@ export class DataStreamConnection extends EventEmitter {
header.protocol = protocol;
header.event = event;

this.sendHDSFrame(header, message);
if (this.state === ConnectionState.READY) {
this.sendHDSFrame(header, message);
}
}

/**
Expand Down
Loading