Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Bump to 1.0 #676

Closed
hobbyquaker opened this issue Jun 20, 2019 · 22 comments
Closed

Suggestion: Bump to 1.0 #676

hobbyquaker opened this issue Jun 20, 2019 · 22 comments
Labels
discussion long running Issues which should be excluded from the stale bot

Comments

@hobbyquaker
Copy link
Contributor

hobbyquaker commented Jun 20, 2019

Hi!
I'm maintaining two projects that depend on HAP-Nodejs, both have quite a bunch of users that are using them since years "in production". As HAP-Nodejs can be considered stable for a long time now I suggest to bump the Version to 1.0.
Would have some advantages: You could fully utilize the semantic versioning scheme, patch only for bugfixes, minor for compatible changes/features, major for breaking changes. With the current 0.x scheme this is not possible, patch is bumped for features, changes and bugfixes and the role of the minor is unclear.
For me as a maintainer of packages depending on HAP-Nodejs it would be much easier to specify a proper version range in the package.json - and last but not least: I see no reason for not doing it :-)
@KhaosT what do you think?
Regards,
Sebastian

@Shaquu
Copy link
Contributor

Shaquu commented Jun 20, 2019

+1 for semantic versioning
I have the same situation here

@hassankhan
Copy link
Contributor

hassankhan commented Aug 24, 2019

Here's a list of things I'd like to see before v1:

  • Remove buffer-shim
  • Lose legacy compatibility (Node 10+ only)
  • Transitioning node-persist to v3.0
  • Use Promises as well as callbacks
  • Improve unit test coverage
  • Create integration test suite using hap-client
  • Add code quality tooling (ESLint + Prettier)
  • Set up CI/CD process
  • Add contributing documentation

Obviously all of them may not be realistic, but I'd love to hear other contributors' thoughts

@Apollon77
Copy link
Contributor

Why break nodejs 8 before it is eol? Or wait till next April. ;-)
What benefit would it have to only support node 10+?

@hobbyquaker
Copy link
Contributor Author

hobbyquaker commented Aug 24, 2019

@hassankhan Sounds legit :)

Create integration test suite using hap-client
Set up CI/CD process

I can offer my help regarding integration tests and travis setup, I think we could reuse a lot of the testing setup of https://github.com/hobbyquaker/homekit2mqtt

Why break nodejs 8 before it is eol?

I would also suggest to support all versions as long as they are in maintenance, so for Node 8 until December 2019:

When I look at Hassans Todo for 1.0 - this will take a bit of time - So I guess 1.0 will be done when Node 8 is already EOL.

@Supereg
Copy link
Member

Supereg commented Jan 16, 2020

#778

@Supereg Supereg pinned this issue Apr 8, 2020
@stale stale bot closed this as completed Apr 15, 2020
@Supereg Supereg reopened this Apr 15, 2020
@stale stale bot removed the stale label Apr 15, 2020
@stale

This comment has been minimized.

@stale stale bot added the stale label Aug 18, 2020
@stale stale bot closed this as completed Aug 25, 2020
@Supereg Supereg reopened this Aug 25, 2020
@stale stale bot removed the stale label Aug 25, 2020
@stale
Copy link

stale bot commented Oct 24, 2020

This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the stale label Oct 24, 2020
@stale stale bot closed this as completed Oct 31, 2020
@Supereg Supereg reopened this Oct 31, 2020
@Supereg Supereg added the long running Issues which should be excluded from the stale bot label Nov 11, 2020
@crxporter
Copy link

Can I add a bump and a vote for this? Semantic versioning would be helpful so we know about all breaking changes and can act accordingly!

As always, thanks for all your hard work!

@Supereg
Copy link
Member

Supereg commented Apr 18, 2021

v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).

@crxporter
Copy link

v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).

So, it's been another year and we've gone through 0.9 and now 0.10... any new plans for 1.0 and true semver support?

@crxporter
Copy link

Hello again. I'm back with a yearly reminder that the projects who depend on this library would really appreciate semantic versioning.

Is 2023 the year?!

@crxporter
Copy link

Please?

How many more years do I need to come beg for this until we get semver and bump to 1.0?

@hjdhjd
Copy link
Contributor

hjdhjd commented Apr 11, 2024

Some day, but not today. It will come…a little housecleaning first.

@bwp91 bwp91 unpinned this issue May 31, 2024
@Shaquu
Copy link
Contributor

Shaquu commented Jun 24, 2024

Bump :)

Guys, SemVer is a very good thing.

Also, in node based projects, it allows using version regex in package.json, at the end, someone will be able to automatically update to some bugfix version without the need to pull the change manually by each project.

@hjdhjd
Copy link
Contributor

hjdhjd commented Jun 24, 2024

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

@Shaquu
Copy link
Contributor

Shaquu commented Jun 25, 2024

@hjdhjd After my bump there is a PR ;) #1045

@crxporter
Copy link

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

@hjdhjd hjdhjd closed this as completed Jun 25, 2024
@hjdhjd
Copy link
Contributor

hjdhjd commented Jun 25, 2024

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

Correlation isn’t causation. Closing this.

@Shaquu
Copy link
Contributor

Shaquu commented Jun 25, 2024

lol

@hjdhjd
Copy link
Contributor

hjdhjd commented Jun 25, 2024

Reopening until we actually release 1.0.0…got ahead of myself. 😄

@hjdhjd hjdhjd reopened this Jun 25, 2024
@hjdhjd
Copy link
Contributor

hjdhjd commented Jun 25, 2024

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

It will come…we had a couple of things to close out which have been in the past few days/weeks…there’s one more potentially, but we may push it to a post-1.0 release.

@Shaquu
Copy link
Contributor

Shaquu commented Jul 11, 2024

GG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion long running Issues which should be excluded from the stale bot
Projects
None yet
Development

No branches or pull requests

8 participants