Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New core integration for VegeHub #129598

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from

Conversation

GhoweVege
Copy link

@GhoweVege GhoweVege commented Oct 31, 2024

Proposed change

I work for a company called Vegetronix. We would like to officially add support for connecting our VegeHub product to Home Assistant. I have attempted to do everything as instructed, but I am brand new to contributing to open source projects, so if I need to change the way I did anything, please let me know. Thank you.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GhoweVege

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrations should have their logic to connect with the device or service in a library published on PyPi

@GhoweVege
Copy link
Author

Sorry, this is my first time doing this. I usually write code for embedded platforms, so I'm trying to learn.

When you say that I should put the "logic to connect with the device" into its own library, what does that mean exactly? The integration only uses API calls to send and receive data from the device. Should I write a library with those specific API calls in it?

@joostlek
Copy link
Member

Yep!

@GhoweVege
Copy link
Author

OK, thank you. I will get to work on it.

@GhoweVege GhoweVege changed the title Initial commit for VegeHub integration VegeHub integration Nov 4, 2024
@GhoweVege GhoweVege changed the title VegeHub integration New core integration for VegeHub Nov 4, 2024
@GhoweVege
Copy link
Author

Ok, it took a few days of learning, but I think it's fixed. I have a library on PyPI now, and the integration uses that to connect with the device.

@GhoweVege GhoweVege marked this pull request as ready for review November 8, 2024 16:24
homeassistant/components/vegehub/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/vegehub/http_api.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/switch.py Outdated Show resolved Hide resolved
homeassistant/components/vegehub/const.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants