-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New core integration for VegeHub #129598
base: dev
Are you sure you want to change the base?
New core integration for VegeHub #129598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GhoweVege
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrations should have their logic to connect with the device or service in a library published on PyPi
Sorry, this is my first time doing this. I usually write code for embedded platforms, so I'm trying to learn. When you say that I should put the "logic to connect with the device" into its own library, what does that mean exactly? The integration only uses API calls to send and receive data from the device. Should I write a library with those specific API calls in it? |
Yep! |
OK, thank you. I will get to work on it. |
Ok, it took a few days of learning, but I think it's fixed. I have a library on PyPI now, and the integration uses that to connect with the device. |
Co-authored-by: Josef Zweck <[email protected]>
Co-authored-by: Josef Zweck <[email protected]>
Proposed change
I work for a company called Vegetronix. We would like to officially add support for connecting our VegeHub product to Home Assistant. I have attempted to do everything as instructed, but I am brand new to contributing to open source projects, so if I need to change the way I did anything, please let me know. Thank you.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: