From 06a4c226fdc180e59e66d0d4fe33894e7d6c7802 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Mon, 11 Jul 2022 16:44:44 +0200 Subject: [PATCH] Remove konnected from mypy ignore list (#75003) --- homeassistant/components/konnected/__init__.py | 2 +- homeassistant/components/konnected/config_flow.py | 12 +++++++----- mypy.ini | 6 ------ script/hassfest/mypy_config.py | 2 -- 4 files changed, 8 insertions(+), 14 deletions(-) diff --git a/homeassistant/components/konnected/__init__.py b/homeassistant/components/konnected/__init__.py index 9844076633468..620ed12ac54f1 100644 --- a/homeassistant/components/konnected/__init__.py +++ b/homeassistant/components/konnected/__init__.py @@ -419,7 +419,7 @@ async def get(self, request: Request, device_id) -> Response: resp = {} if request.query.get(CONF_ZONE): resp[CONF_ZONE] = zone_num - else: + elif zone_num: resp[CONF_PIN] = ZONE_TO_PIN[zone_num] # Make sure entity is setup diff --git a/homeassistant/components/konnected/config_flow.py b/homeassistant/components/konnected/config_flow.py index 94a58227c56c9..fcf94a38c18ad 100644 --- a/homeassistant/components/konnected/config_flow.py +++ b/homeassistant/components/konnected/config_flow.py @@ -6,6 +6,7 @@ import logging import random import string +from typing import Any from urllib.parse import urlparse import voluptuous as vol @@ -171,11 +172,11 @@ class KonnectedFlowHandler(config_entries.ConfigFlow, domain=DOMAIN): VERSION = 1 # class variable to store/share discovered host information - discovered_hosts = {} + discovered_hosts: dict[str, dict[str, Any]] = {} def __init__(self) -> None: """Initialize the Konnected flow.""" - self.data = {} + self.data: dict[str, Any] = {} self.options = OPTIONS_SCHEMA({CONF_IO: {}}) async def async_gen_config(self, host, port): @@ -271,6 +272,7 @@ async def async_step_ssdp(self, discovery_info: ssdp.SsdpServiceInfo) -> FlowRes _LOGGER.error("Malformed Konnected SSDP info") else: # extract host/port from ssdp_location + assert discovery_info.ssdp_location netloc = urlparse(discovery_info.ssdp_location).netloc.split(":") self._async_abort_entries_match( {CONF_HOST: netloc[0], CONF_PORT: int(netloc[1])} @@ -392,10 +394,10 @@ def __init__(self, config_entry: config_entries.ConfigEntry) -> None: self.current_opt = self.entry.options or self.entry.data[CONF_DEFAULT_OPTIONS] # as config proceeds we'll build up new options and then replace what's in the config entry - self.new_opt = {CONF_IO: {}} + self.new_opt: dict[str, dict[str, Any]] = {CONF_IO: {}} self.active_cfg = None - self.io_cfg = {} - self.current_states = [] + self.io_cfg: dict[str, Any] = {} + self.current_states: list[dict[str, Any]] = [] self.current_state = 1 @callback diff --git a/mypy.ini b/mypy.ini index 4975e893a383c..ca7fd4a15c2cd 100644 --- a/mypy.ini +++ b/mypy.ini @@ -2690,12 +2690,6 @@ ignore_errors = true [mypy-homeassistant.components.izone.climate] ignore_errors = true -[mypy-homeassistant.components.konnected] -ignore_errors = true - -[mypy-homeassistant.components.konnected.config_flow] -ignore_errors = true - [mypy-homeassistant.components.lovelace] ignore_errors = true diff --git a/script/hassfest/mypy_config.py b/script/hassfest/mypy_config.py index d9a63aeb11f43..21309560eb31f 100644 --- a/script/hassfest/mypy_config.py +++ b/script/hassfest/mypy_config.py @@ -31,8 +31,6 @@ "homeassistant.components.icloud.device_tracker", "homeassistant.components.icloud.sensor", "homeassistant.components.izone.climate", - "homeassistant.components.konnected", - "homeassistant.components.konnected.config_flow", "homeassistant.components.lovelace", "homeassistant.components.lovelace.dashboard", "homeassistant.components.lovelace.resources",