Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Align version check #6413

Merged
merged 5 commits into from
Oct 16, 2024
Merged

refactor: Align version check #6413

merged 5 commits into from
Oct 16, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 15, 2024

This PR's main point is to align the version check of upstream packages. The following things have been done:

  1. Uppercase the name as they are constants.
  2. Use the following naming PACKAGE_OPERATOR_MAJOR_MINOR_MICRO.
  3. Switch the comparison to a tuple to avoid the overhead of creating Version just for checks and avoiding something like Version(Version(bokeh.__version__).base_version) to get around pre-release versions.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 94.07895% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (0201b94) to head (970191b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/core/util.py 83.33% 2 Missing ⚠️
holoviews/core/data/ibis.py 94.11% 1 Missing ⚠️
holoviews/operation/element.py 80.00% 1 Missing ⚠️
holoviews/plotting/mpl/__init__.py 50.00% 1 Missing ⚠️
holoviews/plotting/mpl/chart.py 75.00% 1 Missing ⚠️
holoviews/plotting/renderer.py 66.66% 1 Missing ⚠️
...oviews/tests/plotting/bokeh/test_annotationplot.py 90.00% 1 Missing ⚠️
holoviews/tests/ui/bokeh/test_callback.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6413      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         323      323              
  Lines       68581    68566      -15     
==========================================
- Hits        60695    60678      -17     
- Misses       7886     7888       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Oct 15, 2024
@hoxbro hoxbro changed the title style: Align version check refactor: Align version check Oct 16, 2024
@hoxbro hoxbro marked this pull request as ready for review October 16, 2024 10:49
@hoxbro hoxbro merged commit 31ee32d into main Oct 16, 2024
14 checks passed
@hoxbro hoxbro deleted the style_align_version branch October 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants