Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup positioning on polygons #6411

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Fix popup positioning on polygons #6411

merged 5 commits into from
Oct 15, 2024

Conversation

philippjfr
Copy link
Member

The coordinate calculation for popups did not handle nested multi-array data as occurs when plotting polygons.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (4286d42) to head (8ccc5f5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/tests/ui/bokeh/test_callback.py 74.07% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6411    +/-   ##
========================================
  Coverage   88.48%   88.49%            
========================================
  Files         323      323            
  Lines       68469    68589   +120     
========================================
+ Hits        60588    60701   +113     
- Misses       7881     7888     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

holoviews/tests/ui/bokeh/test_callback.py Outdated Show resolved Hide resolved
holoviews/plotting/bokeh/callbacks.py Show resolved Hide resolved
holoviews/plotting/bokeh/callbacks.py Outdated Show resolved Hide resolved
@hoxbro hoxbro merged commit 21231c1 into main Oct 15, 2024
14 checks passed
@hoxbro hoxbro deleted the popup_polygons branch October 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants