Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibis: update deprecated call to order_by #5878

Closed
wants to merge 1 commit into from
Closed

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Sep 7, 2023

This PR takes care of this warning:

holoviews/tests/core/data/test_ibisinterface.py: 16 warnings
  /Users/mliquet/miniconda3/envs/hv39/lib/python3.9/site-packages/ibis/expr/types/relations.py:1268: FutureWarning: `table.order_by((key, True)) and table.order_by((key, False)) syntax` is deprecated as of v6.0, removed in v7.0; Use ibis.desc(key) or ibis.asc(key) instead

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #5878 (1834387) into main (9d74f7e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5878   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files         310      310           
  Lines       63983    63985    +2     
=======================================
+ Hits        56529    56531    +2     
  Misses       7454     7454           
Flag Coverage Δ
ui-tests 23.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/core/data/ibis.py 77.01% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member

hoxbro commented Sep 9, 2023

I have also removed it in #5854. But I haven't gotten around to finishing up that PR 🙁

@maximlt
Copy link
Member Author

maximlt commented Sep 9, 2023

Oh yes I missed that!

@maximlt maximlt closed this Sep 9, 2023
@hoxbro hoxbro deleted the ibis_order_warning branch September 11, 2023 09:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants