New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional parameters are not concated #389

Open

championswimmer opened this issue Mar 23, 2018 · 1 comment

Contributor

championswimmer commented Mar 23, 2018

Check here
https://github.com/holidayextras/jsonapi-server/blob/master/lib/swagger/paths.js#L290

wrong

pathDefinition.parameters.concat(additionalParams)

should be

pathDefinition.parameters = pathDefinition.parameters.concat(additionalParams)

Contributor

pmcnr-hx commented Apr 6, 2018

Indeed! concat doesn't mutate it's argument. Will fix. Thanks for reporting!

LatifahParara mentioned this issue

FixedConcat - Updated path definition #393

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment