Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distutils is deprecated #267

Closed
TrianecT-Wouter opened this issue Dec 16, 2024 · 1 comment
Closed

Distutils is deprecated #267

TrianecT-Wouter opened this issue Dec 16, 2024 · 1 comment

Comments

@TrianecT-Wouter
Copy link
Contributor

See also: https://docs.python.org/3.12/library/distutils.html

and

https://peps.python.org/pep-0632/#migration-advice
TrianecT-Wouter added a commit to TrianecT-Wouter/pyedflib that referenced this issue Dec 16, 2024
@TrianecT-Wouter
Removed references to distutils. Distutils is deprecated as mentioned…
51e111f 
… in holgern#267
@TrianecT-Wouter TrianecT-Wouter mentioned this issue Dec 16, 2024
Merged
skjerns pushed a commit that referenced this issue Jan 22, 2025
@TrianecT-Wouter
Converted assert of phys_min and phys_max into warnings (#266)
9f8dde4 
* Update highlevel.py

Converted assert's into warnings. Reason:

in some cases, storing an edf file fails because of roundoff errors:
e.g. `phys_min -3565.82 vs. signal_min 3565.8200000000000006` will fail in write_edf (but shouldn't)

* Removed references to distutils. Distutils is deprecated as mentioned in #267

* Updated tests for warnings in case phys_min > sig.min()

* Added threshold for warning in case of small differences between sig_min and physical_min
Updated tests as well.

* Fix unit test.
@skjerns
Copy link
Collaborator

skjerns commented Jan 23, 2025 •
edited
Loading

fixed by #266

@skjerns skjerns closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skjerns @TrianecT-Wouter