Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hof/fmt: prettier rust plugin is failing on testcase #407

Open
verdverm opened this issue Dec 28, 2024 · 1 comment
Open

hof/fmt: prettier rust plugin is failing on testcase #407

verdverm opened this issue Dec 28, 2024 · 1 comment

Comments

@verdverm
Copy link
Member

disabled for now

386 : Container.withExec(args: ["hof", "run", "rs.txt"]): Container!
386 : [2.9s] | 
386 : [2.9s] | 
386 : [2.9s] | >>> exec hof fmt in.rs -v 1
386 : [2.9s] | [stdout]
386 : [2.9s] | formatting 1 file(s) from in.rs
386 : [2.9s] | 
386 : [2.9s] | InvalidDocError: Unexpected doc.type 'concat'.
386 : [2.9s] | Expected it to be 'cursor', 'indent', 'align', 'trim', 'group', 'fill', 'if-break', 'indent-if-break', 'line-suffix', 'line-suffix-boundary', 'line', 'label', or 'break-parent'.
386 : [2.9s] | 
386 : [2.9s] | while formatting source: error while formatting in.rs
386 : [2.9s] | encountered 1 errors while formatting
386 : [2.9s] | [exit status 1]
386 : [2.9s] | FAIL: rs.txt:1: unexpected exec command failure
386 : [2.9s] | 
386 : [2.9s] | >>> exec hof fmt in.rs -v 1
386 : [2.9s] | [stdout]
386 : [2.9s] | formatting 1 file(s) from in.rs
386 : [2.9s] | 
386 : [2.9s] | InvalidDocError: Unexpected doc.type 'concat'.
386 : [2.9s] | Expected it to be 'cursor', 'indent', 'align', 'trim', 'group', 'fill', 'if-break', 'indent-if-break', 'line-suffix', 'line-suffix-boundary', 'line', 'label', or 'break-parent'.
386 : [2.9s] | 
386 : [2.9s] | while formatting source: error while formatting in.rs
386 : [2.9s] | encountered 1 errors while formatting
386 : [2.9s] | [exit status 1]
386 : [2.9s] | FAIL: rs.txt:1: unexpected exec command failure
386 : [2.9s] | 
386 : Container.withExec ERROR [2.9s]
@verdverm
Copy link
Member Author

verdverm commented Dec 28, 2024

probably worth considering making a dedicated formatter for rust using cargo-fmt or whatever they mainly use in the Rust community

the plugin has some good thoughts on the tradeoffs: https://github.com/jinxdash/prettier-plugin-rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant