Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSwipeNext stuck #207

Open
Salmankhan033 opened this issue May 24, 2022 · 4 comments
Open

onSwipeNext stuck #207

Salmankhan033 opened this issue May 24, 2022 · 4 comments

Comments

@Salmankhan033
Copy link

Salmankhan033 commented May 24, 2022

When I select the date after 2 or 3 years from the current date, the onSwipeNext stuck and can't go next.
when swipePre after that it can swipe next.

sometimes gives this Warning
LOG VirtualizedList: You have a large list that is slow to update - make sure your renderItem function renders components that follow React performance best practices like PureComponent, shouldComponentUpdate, etc. {"contentLength": 40590, "dt": 3129, "prevDt": 680}

@pdpino
Copy link
Collaborator

pdpino commented May 24, 2022

This is related to the component performance, which I'm trying to improve right now, but is taking me a while.
(I've seen the same warning regarding the VirtualizedList)

When I select the date after 2 or 3 years from the current date, the onSwipeNext stuck and can't go next.
when swipePre after that it can swipe next.

In the current code, moving years generates large amounts of data for the internal VirtualizedList, which can cause issues like what you describe. We can try to address the case of moving years/months at once.

@Salmankhan033
Copy link
Author

It's also stuck when changing for one or 2 days.

@pdpino
Copy link
Collaborator

pdpino commented May 26, 2022

It's also stuck when changing for one or 2 days.

Can you provide the code to reproduce or a video

@pdpino pdpino added the status: waiting reply Waiting a reply from the issue's author label May 27, 2022
@Salmankhan033
Copy link
Author

Salmankhan033 commented Jun 2, 2022

Thanks for the quick response
watch the video
now it's also doing when going 4 or 5 next.

Screen.Recording.2022-06-02.at.5.19.03.PM.mov

@pdpino pdpino removed the status: waiting reply Waiting a reply from the issue's author label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants