Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_conllu throws errors with enhanced dependencies in UD-r2.2 #14

Open
venkatasg opened this issue Jun 19, 2018 · 3 comments
Open

load_conllu throws errors with enhanced dependencies in UD-r2.2 #14

venkatasg opened this issue Jun 19, 2018 · 3 comments

Comments

@venkatasg
Copy link
Contributor

In UD-r2.2, to accomodate the use of empty nodes for the analysis of ellipsis in enhanced dependencies, the HEAD(gov in code) column is set to _. This throws an error in the load_conllu function, since DepTriple is called with int(gov) as one of the arguments. UD explains these nodes here and here.

Fix is easy enough. One can check the first column for '.', since UD stipulates that empty nodes must have index of the form i.1, where i is the index of referent of ellipsis. If '.' exists, ignore that line. Unless there is some information we can extract from the empty node?

@venkatasg venkatasg changed the title load_conllu throws errors with enhanced dependencies in UD-r2.2 load_conllu throws errors with enhanced dependencies in UD-r2.2 Jun 19, 2018
@sheng-z
Copy link
Collaborator

sheng-z commented Jun 20, 2018

Yes, that's an easy workaround, but it loses empty nodes which are potentially useful for PredPatt. A better solution is to rewrite the way PredPatt deals with the UD index. That requires more efforts.

@venkatasg
Copy link
Contributor Author

I’m not sure how useful it will be for PredPatt. Firstly I could find no more than 30 instances of this kind of empty nodes in UD. I’ll look into specific examples but in a sentence like ‘Bill ate cookies, and Tom cake’, the HEAD of Tom is still ate I believe? Or perhaps conjunction plays a role in this.

@venkatasg
Copy link
Contributor Author

Does PredPatt use any information from enhanced dependencies at all? Right now I don't think so, and if we want it to in future, that will involve a lot of changes. For now, I think its a good idea to just ignore empty nodes, so that PredPatt doesn't throw an error with UD-r2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants