Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward call sequence error #78

Open
IL0co opened this issue Aug 14, 2020 · 0 comments
Open

Forward call sequence error #78

IL0co opened this issue Aug 14, 2020 · 0 comments

Comments

@IL0co
Copy link
Collaborator

IL0co commented Aug 14, 2020

I noticed an error in the order of calling the "Shop_OnMenuTitle" forward, it is called after all the CallBacks of the category, which is strange to my mind, because it should be called first.

Correction option:

  • make it call before calling callbacks

How did I find it?

  • I needed to get data about where the menu opens (in purchase or in inventory) in the Shop_CategoryDisplayCallback callback, but since it did not have data about ShopAction (I wrote about this in another issue), I decided used the forward "Shop_OnMenuTitle", and then I noticed that it is called after Shop_CategoryDisplayCallback was called

Shop version: 3.05D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants