Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package compatible with PHP 8.4 #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adrmrn
Copy link

@adrmrn adrmrn commented Nov 28, 2024

Hi! I have upgraded to PHP 8.4 in my project recently, and I noticed a few deprecation notices, e.g.,

Deprecated: Qdrant\Qdrant::collections(): Implicitly marking parameter $collectionName as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/hkulekci/qdrant/src/Qdrant.php on line 23

Deprecated: Qdrant\Http\Builder::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/hkulekci/qdrant/src/Http/Builder.php on line 18

RFC: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

So I decided to fix the issues to get rid of notices. Changes are backward compatible.
I have also defined a job to run tests with PHP 8.4.

Let me know wdyt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant