Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein vector readability #4

Open
serbulent opened this issue Aug 27, 2019 · 4 comments
Open

Protein vector readability #4

serbulent opened this issue Aug 27, 2019 · 4 comments

Comments

@serbulent
Copy link

Created protein vectors saved in a list by the getligprotvec.py in order to protein names in smiles_sample.txt. For big files it creates a readability problem. A dictionary might help for this issue such as ['protname1':[vectorvalue1, vectorvalue2], ['protname2':[vectorvalue1, vectorvalue2] ... ]

@hkmztrk
Copy link
Owner

hkmztrk commented Aug 27, 2019

Thanks for the feedback and suggestion!

Could you tell about what kind of readability problem occurs? Does it take too long to read or something else?

@serbulent
Copy link
Author

No, the issue is not technical, what I mean is you should map them one by one to your original protein list to access them later by using accesion id and it might be error prone for user. If it is saved in a dictionary then you can access them more easily.

@hkmztrk
Copy link
Owner

hkmztrk commented Aug 29, 2019

It assumes you are using the same order given in your input, but yes saving in a dictionary might make things easier.

I'll look into it when I find time. Thanks.

@serbulent
Copy link
Author

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants