Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment plan misses dependency #1463

Open
obycode opened this issue May 23, 2024 · 3 comments
Open

Deployment plan misses dependency #1463

obycode opened this issue May 23, 2024 · 3 comments
Assignees

Comments

@obycode
Copy link
Member

obycode commented May 23, 2024

Describe the bug
In this repo when Clarinet generates a deployment plan, it fails to deploy the util contract before the asset-manager contract, causing:

error: use of unresolved contract 'ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.util'

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repo: [email protected]:CyrusVorwald/balanced-clarity-contracts.git
  2. Checkout the commit with the error: git checkout ef385bb57738de731902c6a372e77646ee281f87
  3. Run the check: clarinet check
  4. See error

Expected behavior
This dependency should be detected and the contracts should be deployed in the correct order.

@CyrusVorwald
Copy link

cross posting from the discord:

i have the same issue in this project and commit CyrusVorwald/xcall-clarity-contracts@ca75c11

i ran clarinet check which added util at the end of deployments/default.simnet-plan.yaml. i manually moved it to the start of the list, but it still has the same error. also, i am importing other contracts (ie rlp-decode) without error and that is at the bottom of the list

i ran npm test which moved it to the bottom of the list and in both cases the error use of unresolved contract 'ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.util' occurs

@CyrusVorwald
Copy link

it seems that if i copy over util into the contract that's importing it and call directly from there, and then undo those changes, it works

@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools May 28, 2024
@hugocaillard
Copy link
Collaborator

I'll have a look this week

@hugocaillard hugocaillard moved this from 📋 Backlog to 🏗 In Progress in DevTools Jul 1, 2024
@smcclellan smcclellan moved this from 🏗 In Progress to 📋 Backlog in DevTools Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants