Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Conflicts with nwidart/laravel-modules #194

Open
secrethash opened this issue Nov 30, 2024 · 1 comment
Open

[Bug]: Conflicts with nwidart/laravel-modules #194

secrethash opened this issue Nov 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@secrethash
Copy link

What happened?

I have an application with a huge codebase which uses nwidart/laravel-modules package for modules. I installed verbs too, but as it has a dependency of internachi/modular it somehow throws weird error on my application.

Not exactly sure where the conflicts between those two packages are, but I found out that both the packages uses the same bootstrap/cache/modules.php file to cache the modules and both expect different data structure. The exception I encounter is Undefined array key "name" which after some digging found out that since module.php file is present (created by nwidart/laravel-modules), internachi/modular is also looking for the cache with array key name.

My question is, do we really require internachi/modular as a dependency for verbs to work?

How to reproduce the bug

  • Install verbs alongside nwidart/laravel-modules
  • Create and enable modules
  • Make your application throw an error from the module.

Package Version

0.6.4

PHP Version

8.3

Laravel Version

11.34.2

Which operating systems does with happen with?

Windows, Linux

Notes

No response

@secrethash secrethash added the bug Something isn't working label Nov 30, 2024
@secrethash secrethash changed the title [Bug]: Sometimes conflicts with nwidart/laravel-modules [Bug]: Conflicts with nwidart/laravel-modules Dec 1, 2024
@inxilpro
Copy link
Contributor

I think modular only needs to be a dev dependency. I'll have to dig into it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants