-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors beforeDestroy component #10
Comments
@hazzo The problem here should have been fixed in 0.3.2, can you test it in 0.3.3? |
Sorry I keep getting this error 😟
|
Can you describe the details of the scene? I tried switching RecyclerView and other views without experiencing problem. |
I will investigate on my build. ;) |
Hi again @hilongjw sorry could you upload your demo without compressing it? I need to reproduce the same effect in your demo that when you scroll up yo load more data. Now I'm loading everything at once at is not ideal 😟 Thanks! |
Thanks! |
The error beforeDestroy is solved. But before destroying the component execute the fetch action. That's not a good practice no? What is the need of it? |
Another thing in your demo on the chat section, it'seems that when you scroll up it loads more elements. Sorry for to many requests 😕 |
@hazzo because my demo is using the local mock data, the problem is that all data will be loaded when scrolling to the end, and I'll fix it. |
@hilongjw yes I am using "local data" too, I mean i get all the data before store it in vuex and in each chat I display the data. Bue it would be perfect that when you scroll to bottom avoid loading all data, only just when scroll up. |
Hi @hilongjw did you have a chance look why fetch action is executed when destroying the component? |
@hazzo got it thank you, I'll check it later. |
any fix on not calling the fetch function before destroy
|
Testing the component I get errors when I go to another route before destroying the component.
Example:
The text was updated successfully, but these errors were encountered: