Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store all types of features in the signals table #187

Closed
hiddewie opened this issue Dec 28, 2024 · 3 comments
Closed

Store all types of features in the signals table #187

hiddewie opened this issue Dec 28, 2024 · 3 comments

Comments

@hiddewie
Copy link
Owner

From #182 (comment)

We should put all types of features in the signals table. Currently there is only speed, electrification, and "the rest".

Having all types of signals split up will allow rendering multiple signals in a single location. We can set an arbitrary maximum of 3 icons for a single node.
@hiddewie hiddewie mentioned this issue Dec 28, 2024
Merged
@hiddewie
Copy link
Owner Author

hiddewie commented Dec 28, 2024 •
edited
Loading

proof of concept (Oberhausen, germany):

image

hiddewie added a commit that referenced this issue Dec 28, 2024
@hiddewie
proof of concept for showing multiple signal types on the same node
6333db3 
Part of #187

unsolved problems:
- UI should know which types of signals exist
- hover for icons does not work with `text-field` with `format` structure
- if `text-field` is not used, stacking of signals somehow has to be done manually (take width/height into account)
- with `text-field`, either all text overlaps (because icons can overlap), or labels have to be put into separate layer (text labels are optional)
@hiddewie hiddewie mentioned this issue Dec 28, 2024
Merged
@hiddewie
Copy link
Owner Author

all types of signals work now (even speed signals on main signal), including hovering and optional ref text labels.

image

hiddewie added a commit that referenced this issue Dec 29, 2024
@hiddewie
Show multiple types of signals on same node (#189)
bcdee55 
Part of #187

Part of #141

---

unsolved problems:
- ~UI should know which types of signals exist~
- ~hover for icons does not work with `text-field` with `format`
structure~
- ~if `text-field` is not used, stacking of signals somehow has to be
done manually (take width/height into account)~
- ~with `text-field`, either all text overlaps (because icons can
overlap), or labels have to be put into separate layer (text labels are
optional)~
- ~define ordering of importance of signals~

~Current state: main and distant signals combined~

---

Changes:
- Merge the all railway signal features into a single file
- Update the `signals_with_azimuth` table to contain a column per type
of feature
- The signal views get the responsibility of filtering signals and
ordering them in relative priority
- Show deactivated signals for speed and electrification layers


![image](https://github.com/user-attachments/assets/11f5a433-f6c1-4e64-b90f-33f78544d322)



At most 5 signals on one pole can be combined.



(Oberhausen, Germany,
http://localhost:8000/#view=16.77/51.474918/6.851609&style=signals)

![image](https://github.com/user-attachments/assets/77b187f2-794a-4015-a2ef-537527efce31)
@hiddewie
Copy link
Owner Author

Done in #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiddewie