common/utils/extend_json_encoder.py bug ?

[xiaoshumiao6]

这段代码是BUG嘛？ 还是有意为之

return o.decode("utf-8") >> return obj.decode("utf-8") ??

class ExtendJSONEncoderBytes(json.JSONEncoder):
    def default(self, obj):
        try:
            # 使用convert.register处理会报错 ValueError: Circular reference detected
            # 不是utf-8格式的bytes格式需要先进行base64编码转换
            if isinstance(obj, bytes):
                try:
                    return o.decode("utf-8")
                except:
                    return base64.b64encode(obj).decode("utf-8")
            else:
                return convert(obj)
        except TypeError:
            print(type(obj))
            return super(ExtendJSONEncoderBytes, self).default(obj)

[LeoQuote]

应该是写错了, 有实际的影响吗?

[xiaoshumiao6]

没有遇到问题； 只是看代码的时候注意到了； 全局搜了下这个类， 应该影响不大

 % grep -r 'ExtendJSONEncoderBytes' *
common/utils/extend_json_encoder.py:class ExtendJSONEncoderBytes(json.JSONEncoder):
common/utils/extend_json_encoder.py:            return super(ExtendJSONEncoderBytes, self).default(obj)
sql/db_diagnostic.py:from common.utils.extend_json_encoder import ExtendJSONEncoder, ExtendJSONEncoderBytes
sql/db_diagnostic.py:    # ExtendJSONEncoderBytes 使用json模块，bigint_as_string只支持simplejson
sql/db_diagnostic.py:        json.dumps(result, cls=ExtendJSONEncoderBytes), content_type="application/json"