Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Period for TOTP is very limited being uint8 #4

Open
designgrill opened this issue Feb 6, 2016 · 2 comments
Open

The Period for TOTP is very limited being uint8 #4

designgrill opened this issue Feb 6, 2016 · 2 comments

Comments

@designgrill
Copy link

Given the value is in seconds, uint8 can't be used to have values like 5 minutes or more. The Period should be allowed to have higher values, even few days if the situation demands.

@hgfischer
Copy link
Owner

I am open to accept pull-requests if they are well tested and if possible don't break the API ;)

@akerl
Copy link

akerl commented Oct 3, 2018

It seems pretty much impossible to do this without at least breaking the part of the API where otp.TOTP and otp.HOTP use uint8s, unless I'm missing something.

I'm also kinda curious what the use case is where you'd want the code to only chance once every few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants