Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call sysgpu device tick #1289

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

RonaldZielaznicki
Copy link
Contributor

@RonaldZielaznicki RonaldZielaznicki commented Oct 21, 2024

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Fixes: #1288

Related to:
#1232
#1252
#1253
#1259
#1270
#1271
#1275

Changes

  1. add: deviceTick call after platform update.
  2. add: display name to error.FailedToConnectToDisplay message.
  3. fix: double free during X11 deinit.

@@ -611,6 +611,7 @@ fn presentFrame(core: *Mod, entities: *mach.Entities.Mod) !void {
if (num_windows > 1) @panic("mach: Core currently only supports a single window");

_ = try state.platform.update();
mach.sysgpu.Impl.deviceTick(state.device);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than putting the tick in every device update, I thought it better to put it somewhere more general.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device.tick with new mach Core backends
2 participants