From d51ba126d917bb752d6e446ee8039f6404a8f3a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julian=20T=C3=B6lle?= <julian.toelle@hetzner-cloud.de>
Date: Thu, 4 Jul 2024 14:39:25 +0200
Subject: [PATCH] feat: necessary features for hcloud-cloud-controller-manager
 (#14)

- Variable to disable HCCM: We want to deploy this from the local
sources
- Variable to disable cloud routes: Does not work with Robot servers,
  which we use in one test suite
- Output for the control-plane server: Used to join the Robot server
- `ENV_NAME` in `env.sh`: Used in HCCM tests to find resources in the
  Cloud API
---
 main-setup.tf | 22 ++++++++++++++++++++--
 outputs.tf    |  5 +++++
 variables.tf  | 10 ++++++++++
 3 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/main-setup.tf b/main-setup.tf
index 09376cc..52c4e71 100644
--- a/main-setup.tf
+++ b/main-setup.tf
@@ -42,8 +42,12 @@ resource "null_resource" "k3sup_control" {
           --disable=servicelb \
           --disable=traefik \
           --flannel-backend=none \
+          %{~if var.use_cloud_routes~}
           --node-external-ip='${hcloud_server.control.ipv4_address}' \
           --node-ip='${hcloud_server_network.control.ip}'" \
+          %{~else~}
+          --node-ip='${hcloud_server.control.ipv4_address}'" \
+          %{~endif~}
         --local-path='${local.kubeconfig_path}'
     EOT
   }
@@ -84,8 +88,12 @@ resource "null_resource" "k3sup_worker" {
         --k3s-channel='${var.k3s_channel}' \
         --k3s-extra-args="\
           --kubelet-arg='cloud-provider=external' \
+          %{~if var.use_cloud_routes~}
           --node-external-ip='${hcloud_server.worker[count.index].ipv4_address}' \
           --node-ip='${hcloud_server_network.worker[count.index].ip}'"
+          %{~else~}
+          --node-ip='${hcloud_server.worker[count.index].ipv4_address}'"
+          %{~endif~}
       EOT
   }
 }
@@ -136,16 +144,19 @@ resource "helm_release" "cilium" {
     value = "kubernetes"
   }
   set {
-    name  = "tunnel"
-    value = "disabled"
+    name  = "routingMode"
+    value = var.use_cloud_routes ? "native" : "tunnel"
   }
   set {
+    # Only used if routingMode=native
     name  = "ipv4NativeRoutingCIDR"
     value = local.cluster_cidr
   }
 }
 
 resource "helm_release" "hcloud_cloud_controller_manager" {
+  count = var.deploy_hccm ? 1 : 0
+
   name       = "hcloud-cloud-controller-manager"
   chart      = "hcloud-cloud-controller-manager"
   repository = "https://charts.hetzner.cloud"
@@ -157,6 +168,12 @@ resource "helm_release" "hcloud_cloud_controller_manager" {
     name  = "networking.enabled"
     value = "true"
   }
+
+  set {
+    name  = "env.HCLOUD_NETWORK_ROUTES_ENABLED.value"
+    value = tostring(var.use_cloud_routes)
+    type  = "string"
+  }
 }
 
 resource "helm_release" "docker_registry" {
@@ -193,6 +210,7 @@ resource "local_file" "env" {
   content         = <<-EOT
     #!/usr/bin/env bash
 
+    export ENV_NAME=${var.name}
     export KUBECONFIG=${data.local_sensitive_file.kubeconfig.filename}
     export SKAFFOLD_DEFAULT_REPO=localhost:${module.registry_control.registry_port}
   EOT
diff --git a/outputs.tf b/outputs.tf
index a2ac6de..c93024d 100644
--- a/outputs.tf
+++ b/outputs.tf
@@ -7,3 +7,8 @@ output "ssh_public_key_filename" {
   description = "Path to the public SSH Key"
   value       = local_sensitive_file.ssh_public.filename
 }
+
+output "control_server_ipv4" {
+  description = "Public IPv4 of the control node"
+  value       = hcloud_server.control.ipv4_address
+}
diff --git a/variables.tf b/variables.tf
index 9efeef6..f9e493b 100644
--- a/variables.tf
+++ b/variables.tf
@@ -5,6 +5,16 @@ variable "name" {
   default     = "dev"
 }
 
+variable "deploy_hccm" {
+  description = "Deploy hcloud-cloud-controller-manager through Helm"
+  type        = bool
+  default     = true
+}
+variable "use_cloud_routes" {
+  description = "Use the Hetzner Cloud network routes for Pod traffic. Enables hcloud-cloud-controller-manager routes controller and Cilium native routing. Does not work with Robot servers."
+  type        = bool
+  default     = true
+}
 variable "worker_count" {
   description = "Number of worker for the environment"
   type        = number