Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Node 7.9.0 32 bit #43

Open
agjs opened this issue Feb 5, 2018 · 1 comment
Open

Issue with Node 7.9.0 32 bit #43

agjs opened this issue Feb 5, 2018 · 1 comment

Comments

@agjs
Copy link
Contributor

agjs commented Feb 5, 2018

When running node-nightly on 32-bit version, process.arch returns "ia32" which doesn't exist anywhere in node repositories neither in the files array in node-nightly-version module.

I've fixed this for myself by modifying the index.js in node-nightly.

// line 24
arch = process.arch === 'ia32' ? 'x86' : process.arch,

This fixed it for me. I'm not gonna do the pull request since this can be done better. I just wanted to inform you of this issue as other people might have the same issues.

@agjs agjs closed this as completed Feb 5, 2018
@agjs agjs reopened this Feb 5, 2018
@agjs
Copy link
Contributor Author

agjs commented Feb 5, 2018

I've created a pull request. In case you find the changes acceptable, please merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant