Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear orphan coverage objects #891

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Clear orphan coverage objects #891

merged 5 commits into from
Nov 18, 2024

Conversation

macpie
Copy link
Member

@macpie macpie commented Nov 5, 2024

If we run, it will delete:

  • Last month = 45k
  • Last week = 75K

Total current records 120k

Doing last period and keeping the last 10 valid should delete about 62k coverage objects.

@bbalser
Copy link
Contributor

bbalser commented Nov 6, 2024

are you proposing that this function is run once a day as part of the cleanup process after rewards have been output?

@macpie
Copy link
Member Author

macpie commented Nov 6, 2024

are you proposing that this function is run once a day as part of the cleanup process after rewards have been output?

I was looking at it more before making a decision but I think yes that would be the goal. We just need to decide if we want to remove month old or week old.

@macpie
Copy link
Member Author

macpie commented Nov 6, 2024

@thehardbits Could you confirm that any heartbeat that comes in should always have the latest coverage object uuid?

@thehardbits
Copy link
Contributor

thehardbits commented Nov 7, 2024

No, unfortunately that's not the case. Sometimes radio misses the last CO and continues to send old. But radio should not fallback to previously used CO in case it sends new one in HB messages.

@macpie macpie requested a review from bbalser November 11, 2024 17:11
@macpie macpie marked this pull request as ready for review November 12, 2024 17:26
@macpie macpie merged commit 6742f2a into main Nov 18, 2024
17 checks passed
@macpie macpie deleted the macpie/orphan_coverage_objects branch November 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants