Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for mobile verifier #602

Closed
wants to merge 4 commits into from

Conversation

maplant
Copy link
Contributor

@maplant maplant commented Aug 15, 2023

No description provided.

@maplant maplant requested review from bbalser and andymck August 15, 2023 21:25
}
}

async fn rewards(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this function does some of what the actual rewarder does and tests key functions of that flow, an integration test should be using the actual rewarder flow itself rather than shadowing it. Its fine to have prep functions to generate the data etc but i think this rewards function negates a lot of the point of these being integration tests

@maplant maplant closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants