Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - add ability to modify which notifications are seen #247

Open
laboon opened this issue Jul 14, 2022 · 5 comments
Open

Feature request - add ability to modify which notifications are seen #247

laboon opened this issue Jul 14, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request telegram bot

Comments

@laboon
Copy link

laboon commented Jul 14, 2022

I don't particularly care about certain notifications (e.g. block authoring or gain/loss of nominators) - it would be nice to be able to only display the notifications I am interested in (e.g. payouts, change in commission, etc.)

@kukabi
Copy link
Member

kukabi commented Jul 14, 2022

Hi @laboon, thanks for the report, you may turn on/off all types notifications through the /settings command. Please give it a shot and let me know any issues.

@kukabi
Copy link
Member

kukabi commented Jul 14, 2022

Block authoring notifications are under Validator Activity -> Block Authorship, nomination gain/loss are under Nominations, payouts at Validator Activity -> Payout Called.

I think there's no notification for commission change, I'll give it another look and update, I agree it would be a good notification.

@kukabi kukabi self-assigned this Jul 14, 2022
@kukabi kukabi added enhancement New feature or request telegram bot labels Jul 14, 2022
@laboon
Copy link
Author

laboon commented Jul 14, 2022

Thank you! Looking forward to the addition of commission change notifications!

@kukabi
Copy link
Member

kukabi commented Jul 18, 2022

Hi @laboon, sorry for noticing this a bit late, but the bot should already be notifying commission changes. The notification is for when the validator submits a new validate extrinsic successfully, and the commission rate is there alongside other information:

Screen Shot 2022-07-18 at 13 09 46

I think the only way to change the commission is to submit a new validate extrinsic, so you should already be receiving these notifications when there's a commission change.

The opener text declared a new intention to validate is not very user-friendly for nominators, but for the audience of this bot (node operators) I think it is appropriate. If I added a separate notification for commission change (and I did) it would give two notifications, so I would have to remove the validate extrinsic notification, but I think that the complete extrinsic notification is better suited for the use cases of this bot. A commission change notification would definitely make better sense for a nominator bot/app though, which I'm working on too.

Please let me know what you think, thanks:)

EDIT: Actually one way this notification could be more useful is to post only when there's a change to either commission or the nomination blocking status. So it's more like "preferences update" notification rather than "validate intention". Will take a look.

@laboon
Copy link
Author

laboon commented Jul 19, 2022

I didn't notice this as part of the intention to validate myself.

> Actually one way this notification could be more useful is to post only when there's a change to either commission or the nomination blocking status

Yes, exactly! This may be some extra work but for me (as a nominator interested in my validators, so I may not be the target audience exactly), it would be very valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telegram bot
Projects
None yet
Development

No branches or pull requests

2 participants