Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to up to date #122

Open
zhaolinlau opened this issue Jan 29, 2024 · 4 comments
Open

Request to up to date #122

zhaolinlau opened this issue Jan 29, 2024 · 4 comments

Comments

@zhaolinlau
Copy link

May i request to up to date based on the latest vue syntax?

https://github.com/vuejs/language-tools/tree/master/extensions/vscode/syntaxes

@zhaolinlau
Copy link
Author

@confused-Techie

@confused-Techie
Copy link
Collaborator

This isn't a bad idea at all. Since the TextMate grammar this package is based off of was last updated 9 years ago, and obviously with the one you linked being last updated a month ago does seem a whole lot better.

I will mention though, as this is a TextMate grammar with unwieldy Regex that I had no part in writing at all, I'll very likely aim to fully replace the existing Regex with the new stuff from this package, so this may cause some big differences, but hopefully those are only good ones.

If I were able to make a PR would you be willing to test the changes?

@zhaolinlau
Copy link
Author

This isn't a bad idea at all. Since the TextMate grammar this package is based off of was last updated 9 years ago, and obviously with the one you linked being last updated a month ago does seem a whole lot better.

I will mention though, as this is a TextMate grammar with unwieldy Regex that I had no part in writing at all, I'll very likely aim to fully replace the existing Regex with the new stuff from this package, so this may cause some big differences, but hopefully those are only good ones.

If I were able to make a PR would you be willing to test the changes?

sure

@zhaolinlau
Copy link
Author

@confused-Techie any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants