This repository has been archived by the owner on Aug 26, 2020. It is now read-only.
Solution of MAGNUM81 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added type defs for lodash project setup added lodash and request ignore api output files
using chai for assertions and mocha as testing library
also reordered the dependencies. Mixed up npm for a moment. dropped old client app
- enabled bootstrap - played around with the layout - added template classes for State and Props in ExpenseComponent.tsx - this package-lock.json is getting out of hand
also, removed unused imports. Warnings are annoying
- Lifted the state of ExpensesList to App - Moved the NavBar to its own Component class, for clarity
The filter is located in the navbar.
App architecture is fine. No need for such a generic branch now.
Had to refactor some of the NavBar code so that when we choose a filter it notifies App, which in turn will modify its state and update NavBar.
also I now know more about promises in JS, which is great!
For some reason, react-bootstrap's navbar did not work as intended; had to re-add reactstrap
Partial support for frontend receipt adding and visualizing.
mostly spacing and braces placement.
test for picture upload was failing silently all along. Green checkmark !== success. (it is still failing silently)
Only the Comment could be uploaded correctly to the server. Some style work in ModalExpenses.
Solution of MAGNUM81
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.