From 67cc0c8690a7219e8a47cd218c4c4e8b1e08be97 Mon Sep 17 00:00:00 2001
From: Ben Roberts <ben@headsnet.com>
Date: Sun, 2 Jun 2024 10:51:34 +0200
Subject: [PATCH] Remove Gitlab Linting as it is problemmatic

---
 composer.json           |  4 +++-
 grumphp.conventions.yml | 11 -----------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/composer.json b/composer.json
index bbe6e3d..964f6a2 100644
--- a/composer.json
+++ b/composer.json
@@ -6,9 +6,11 @@
     "minimum-stability": "stable",
     "require": {
         "phpro/grumphp": "^2.5",
-        "headsnet/grumphp-gitlab-lint": "^0.1.0",
         "ergebnis/composer-normalize": "^2.2"
     },
+    "suggest": {
+        "headsnet/grumphp-gitlab-lint": "^0.1.0"
+    },
     "config": {
         "allow-plugins": {
             "phpro/grumphp": true,
diff --git a/grumphp.conventions.yml b/grumphp.conventions.yml
index 2a410c6..a8e802e 100644
--- a/grumphp.conventions.yml
+++ b/grumphp.conventions.yml
@@ -4,9 +4,6 @@ parameters:
     convention.git_blacklist.keywords: [ 'die\\(', 'dd\\(', 'dump\\(', 'var_dump\\(', 'exit;' ]
     convention.git_branch_name.blacklist: [ master, main ]
     convention.git_branch_name.whitelist: [ ]
-    convention.gitlab_lint.api_token: 'MY TOKEN'
-    convention.gitlab_lint.gitlab_url: 'gitlab.com/api/v4/projects/:id'
-    convention.gitlab_lint.gitlab_file: '.gitlab-ci.yml'
     convention.doctrine_schema_check.command: './bin/console doctrine:schema:validate --skip-sync'
     convention.lint_twig.command: './bin/console lint:twig templates'
     convention.lint_yaml.command: './bin/console lint:yaml --parse-tags src config tests translations'
@@ -39,10 +36,6 @@ grumphp:
         git_commit_message:
             max_subject_width: 72 # The old-school convention of 65 characters is way too limited
             max_body_width: 72
-        gitlab_lint:
-            api_token: '%convention.gitlab_lint.api_token%'
-            gitlab_url: '%convention.gitlab_lint.gitlab_url%'
-            gitlab_file: '%convention.gitlab_lint.gitlab_file%'
         lint_twig:
             scripts: [["-c", '%convention.lint_twig.command%']]
             triggered_by: [ twig ]
@@ -63,9 +56,6 @@ grumphp:
             testsuite: Unit,Integration
             metadata: { task: paratest }
 
-    extensions:
-        - Headsnet\GrumPHP\GitlabLint\Loader
-
     testsuites:
         git_commit_msg:
             tasks:
@@ -81,7 +71,6 @@ grumphp:
                 - composer_normalize
                 - lint_twig
                 - lint_yaml
-                - gitlab_lint
         my_pre_push:
             tasks:
                 - phpunit_all