Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace (broken) action-updater workflow with Dependabot #267

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Nov 18, 2024

In hazelcast/hz-docs#1024 an action was added to check GitHub Actions dependencies for updated versions, and raise PRs to fix if identified.

This action has been failing for 6 months due to a token issue.

Based on the PRs it previously created, it's looks to have used a former users' token which has since lost permissions.

Although [github-actions-version-updater] offers some additional functionality over Dependabot (e.g. updating via SHA), for our configuration this isn't required. As such we can use Dependabot instead and require no such token configuration.

Post-merge actions:

  • remove the ACTION_UPDATER secret

In hazelcast/hz-docs#1024 an action was added to check GitHub Actions dependencies for updated versions, and raise PRs to fix if identified.

This action [has been failing](https://github.com/hazelcast/hz-docs/actions/workflows/action-updater.yml) for 6 months due to a token issue.

[Based on the PRs it _previously_ created](hazelcast/hz-docs#1024), it's looks to have used a former users' token which has since lost permissions.

Although [`github-actions-version-updater`] offers some additional functionality over Dependabot (e.g. updating via SHA), for _our_ configuration this isn't required. As such we can use Dependabot instead and require no such token configuration.

Post-merge actions:
- [ ] remove the `ACTION_UPDATER` secret
@JackPGreen JackPGreen requested a review from fantkolja November 18, 2024 10:06
@JackPGreen JackPGreen self-assigned this Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for pedantic-goldberg-f76ec1 ready!

Name Link
🔨 Latest commit f9a0d04
🔍 Latest deploy log https://app.netlify.com/sites/pedantic-goldberg-f76ec1/deploys/673b11b48d63cc000893a3c1
😎 Deploy Preview https://deploy-preview-267--pedantic-goldberg-f76ec1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackPGreen JackPGreen merged commit 3030916 into hazelcast:main Nov 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants