Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks like Azure uses '\r\n' carriage returns normally, which messes with Chunked #117

Open
0b1kn00b opened this issue Apr 25, 2020 · 4 comments
Open

Looks like Azure uses '\r\n' carriage returns normally, which messes with Chunked #117

0b1kn00b opened this issue Apr 25, 2020 · 4 comments

Comments

@0b1kn00b
Copy link

0b1kn00b commented Apr 25, 2020 •
edited
Loading

#118
@0b1kn00b
Copy link
Author

0b1kn00b commented Apr 25, 2020 •
edited
Loading

Also, the alignment of Chunks to actual data, so html\r\n$next_size\r\nmore_html is a thing.

On php, in any case

@kevinresol
Copy link
Member

This Chunked thing is just an experiment of mine (and not being actually used in anywhere)... I am not surprised if it is incomplete.

@kevinresol
Copy link
Member

Anyway, do you mind PR-ing a failing test case, or even better with the corresponding solution?

@0b1kn00b
Copy link
Author

0b1kn00b commented Apr 25, 2020 •
edited
Loading

Alright, I'm aiming at supporting chunked responses with SocketClient.
What else is necessary? I've got Fetch working with SocketClient with the above when it fails to find a content-length header here: SocketClient.hx#L72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0b1kn00b @kevinresol