Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love 9 transition #2004

Merged
merged 1 commit into from
Mar 21, 2014
Merged

Love 9 transition #2004

merged 1 commit into from
Mar 21, 2014

Conversation

NimbusBP1729
Copy link
Member

There were a few API changes in love.

they claim this was their biggest change to date, so we'll need to do a good amount of testing with this branch.

In terms of backwards compatibility it would be possible for us to also support love 0.8.0, but i don't imagine we should if love didn't care about it themselves.

We'll also have to verify that the mixpanel code is working correctly, since I'm not too familiar with its usage.

@NimbusBP1729
Copy link
Member Author

prewarning:
https://bitbucket.org/rude/love/downloads

it looks like for MacOSX there is only a 64 bit zip. this may cause issues for some people. if anyone has a 32 bit, let me know if there is an alternative that works for you.

@NimbusBP1729
Copy link
Member Author

i don't feel comfortable with this being merged until someone using linux, someone using osx 64 bit and someone using osx 32 bit have tried this.

@kyleconroy
Copy link
Member

Yeah, I'm actually thinking that this might be a good time to migrate to https://stackmachine.com for releases. I'll look into it.

@kyleconroy
Copy link
Member

Check the Travis build, it looks like conf.lua is wrong.

conf.lua:7: attempt to index field 'screen' (a nil value)

@NimbusBP1729
Copy link
Member Author

this was hopefully an exhaustive attempt. I scanned every method in LÖVE to find out which are no longer being used, grepped our code, and replaced with the new methods.

@danhp
Copy link
Member

danhp commented Jan 30, 2014

ParticleSystem:setGravity became ParticleSystem:setLinearAcceleration.
http://imgur.com/a/RnU9Z

Also

Renamed ParticleSystem:setLifetime and ParticleSystem:setParticleLife to ParticleSystem:setEmitterLifetime and ParticleSystem:setParticleLifetime.

@danhp
Copy link
Member

danhp commented Feb 4, 2014

Everything seems in order!

@edisonout
Copy link
Member

All looks good except my small screen doesn't display everything correctly in windowed mode.

@danhp
Copy link
Member

danhp commented Feb 8, 2014

Fix #2003
Let's us manage #307 with a bit more ease

@danhp
Copy link
Member

danhp commented Feb 20, 2014

This is on standstill....
@edisonout could you make a list of every thing that goes wrong?

@edisonout
Copy link
Member

I think it was literally just the not scaling to my small screen. Some stuff we've coded is relative to the top left corner of the screen, while other stuff is positioned based on window height. Main problem was the bottom of the levels disappearing behind the taskbar.

@edisonout
Copy link
Member

Whooo! I've found a solution and it's only one line long! Need an additional flag "borderless=true".

I've sent @NimbusBP1729 a pull request.

Thank you this thread

Fixes problem with my stupidly small screen
@danhp
Copy link
Member

danhp commented Mar 19, 2014

Final thing to do is to fix the conflict with hiddendoortrigger.lua which has been removed

@danhp danhp merged commit a362f1d into hawkthorne:master Mar 21, 2014
@8bitgentleman
Copy link
Contributor

Do level designers need to do anything different when working with love 9 or when updating old branches to love 9?

@danhp
Copy link
Member

danhp commented Mar 21, 2014

nope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants