-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The player should be allowed more than one quest #2495
Comments
The whole quest module needs to be re-written really Far too much is happening in each npc file rather than in the quest file. The quest items shouldn't have to be manually added/removed for some quests. |
@edisonout Is that happening anywhere? in #2493 I made the laser lotus boss do it manually but thats only because it's not an npc, so it can't use the quest module. |
It might happen in the QFO quest, I'm not sure. |
Some of Frankie's did. I'm not sure about all the ones in the valley. When I did quests only Frankie, Hilda, Juanita and Jerry gave quests. |
Fortunately we don't have to many quests, I think we can get the rest of the quests working with the quest module without a complete rewrite. I agree that will have to be done before this is implemented though. |
I think it's mainly when quests have multiple parts that we have issues. |
Just going to add a comment here for future reference that any quest refactoring needs to take into account that any multi-part quests are a single quest item. This would allow the player to have multiple quests at once and not conflict with multi-part quests. |
At some point we'll need to add support for multiple quests, which shouldn't be too much as quests are now displayed in inventory thanks to @edisonout .
The text was updated successfully, but these errors were encountered: