Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HxSearchBox - fix clear button padding if there is delete icon #656

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

vaclavek
Copy link
Contributor

@vaclavek vaclavek commented Nov 9, 2023

  • Add css class hx-search-box-input-with-clear-icon if there is clear button.
  • Add right padding if there is new css class

image

Fixes #505

@vaclavek vaclavek changed the title HxSearchBox - fix clear button padding if there is delete icon #505 HxSearchBox - fix clear button padding if there is delete icon Nov 9, 2023
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr requested a review from crdo November 9, 2023 23:24
@hakenr hakenr self-assigned this Nov 9, 2023
@crdo
Copy link
Member

crdo commented Nov 10, 2023

@vaclavek if you want to be precise the padding is slightly different for each size (Small, Regular, Large).

@vaclavek
Copy link
Contributor Author

@crdo I have added more input sizes to test page and checked padding on all sizes. The distance of text from X is now same as distance X from right border.
Everything is bathed in sunlight now :)

@hakenr hakenr merged commit 61d1048 into havit:master Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HxSearchBox] Input text is overlapping Clear/Search icon
3 participants