From a86123e16c92e7a0e4c83f6aebf29c04ce4467a4 Mon Sep 17 00:00:00 2001 From: Lyndon Maydwell Date: Thu, 23 Nov 2023 20:31:22 +1000 Subject: [PATCH 1/2] Fixing implementation error for configuration defaults --- src/connector.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/connector.ts b/src/connector.ts index 321a644..fe1766a 100644 --- a/src/connector.ts +++ b/src/connector.ts @@ -250,6 +250,10 @@ export const connector: sdk.Connector = { // TODO: https://github.com/hasura/ndc-typescript-deno/issues/27 Make this add in the defaults update_configuration(configuration: Configuration): Promise { + return Promise.resolve(configuration); + }, + + validate_raw_configuration(configuration: Configuration): Promise { const defaults = { preVendor: true, } @@ -257,10 +261,6 @@ export const connector: sdk.Connector = { return Promise.resolve(response); }, - validate_raw_configuration(configuration: Configuration): Promise { - return Promise.resolve(configuration); - }, - get_schema(config: Configuration): Promise { const result = getInfo(config); return Promise.resolve(result.schema); From 0d39dd01a639d4fc3e5145ec7d195d1239566a82 Mon Sep 17 00:00:00 2001 From: Lyndon Maydwell Date: Fri, 24 Nov 2023 12:22:31 +1000 Subject: [PATCH 2/2] Changelog --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ba9749..35bb8b4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,14 @@ This changelog documents the changes between release versions. Changes to be included in the next upcoming releaase. +## v0.17 + +Fixing issue with preVendor default. + +PR: https://github.com/hasura/ndc-typescript-deno/pull/76 + +* Was only applying the default during user-interactive config flows + ## v0.16 Prevendoring by default.