From ca744ee790a7b8f97ecca71e58d627db86af4cdf Mon Sep 17 00:00:00 2001 From: Lyndon Maydwell Date: Thu, 23 Nov 2023 09:36:23 +1000 Subject: [PATCH 1/3] Prevendor by default to allow users to omit from default configuration --- src/connector.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/connector.ts b/src/connector.ts index 92ad55a..321a644 100644 --- a/src/connector.ts +++ b/src/connector.ts @@ -41,7 +41,7 @@ export const CONFIGURATION_SCHEMA: JSONSchemaObject = { type: 'string' }, preVendor: { - description: 'Perform vendoring prior to inference in a sub-process (default: false)', + description: 'Perform vendoring prior to inference in a sub-process (default: true)', type: 'boolean' }, schemaMode: { @@ -250,7 +250,11 @@ export const connector: sdk.Connector = { // TODO: https://github.com/hasura/ndc-typescript-deno/issues/27 Make this add in the defaults update_configuration(configuration: Configuration): Promise { - return Promise.resolve(configuration); + const defaults = { + preVendor: true, + } + const response = { ...defaults, ...configuration } + return Promise.resolve(response); }, validate_raw_configuration(configuration: Configuration): Promise { From 6d49ffa74f250346e25fe5ff7597a768fd1759f9 Mon Sep 17 00:00:00 2001 From: Lyndon Maydwell Date: Thu, 23 Nov 2023 09:37:24 +1000 Subject: [PATCH 2/3] adding new docker entrypoint config false value for prevendor --- src/entrypoint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/entrypoint.sh b/src/entrypoint.sh index fca3081..5209fbf 100755 --- a/src/entrypoint.sh +++ b/src/entrypoint.sh @@ -37,7 +37,7 @@ then fi # The config is always the same for `connector create` -echo '{"functions": "/functions/index.ts", "vendor": "/functions/vendor", "schemaMode": "READ", "schemaLocation": "/functions/schema.json"}' \ +echo '{"functions": "/functions/index.ts", "vendor": "/functions/vendor", "preVendor": false, "schemaMode": "READ", "schemaLocation": "/functions/schema.json"}' \ > /config.json deno run \ From 24bca841ff5c0b3c6cc0eb0ac3daeb667ebc51a4 Mon Sep 17 00:00:00 2001 From: Lyndon Maydwell Date: Thu, 23 Nov 2023 14:07:21 +1000 Subject: [PATCH 3/3] merge main and changelog --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5ace344..0ba9749 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,14 @@ This changelog documents the changes between release versions. Changes to be included in the next upcoming releaase. +## v0.16 + +Prevendoring by default. + +PR: https://github.com/hasura/ndc-typescript-deno/pull/74 + +* Using defaults of `{"preVendor": true}` to minimise setup required for development + ## v0.15 Updating TypeScript target version from ES2017 to ES2022.