From 802d5bf1190007e1a3bc2868c06d6256d02df725 Mon Sep 17 00:00:00 2001 From: Benoit Ranque Date: Fri, 6 Oct 2023 15:14:04 -0400 Subject: [PATCH] bump ndc-sdk version, remove get_read_regions method --- Cargo.lock | 4 +++- Cargo.toml | 2 +- src/connector.rs | 8 -------- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index b11cf4c..124c5cb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1021,17 +1021,19 @@ dependencies = [ [[package]] name = "ndc-sdk" version = "0.1.0" -source = "git+https://github.com/hasura/ndc-hub.git?rev=4d14c4e#4d14c4e37217edfc6c5c64915a955e9d46b3a946" +source = "git+https://github.com/hasura/ndc-hub.git?rev=6e2b084#6e2b0843b55775efc9d3d534f662b274bcef071c" dependencies = [ "async-trait", "axum", "axum-macros", "clap", "gdc_rust_types", + "http", "indexmap 1.9.3", "ndc-client", "ndc-test", "opentelemetry", + "opentelemetry-http", "opentelemetry-otlp", "opentelemetry-semantic-conventions", "opentelemetry_api", diff --git a/Cargo.toml b/Cargo.toml index d0cb62a..2c4d896 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -11,7 +11,7 @@ tokio = { version = "1.27.0", features = [ "rt-multi-thread", "signal", ] } -ndc-sdk = { git = "https://github.com/hasura/ndc-hub.git", rev = "4d14c4e", package = "ndc-sdk" } +ndc-sdk = { git = "https://github.com/hasura/ndc-hub.git", rev = "6e2b084", package = "ndc-sdk" } peg = "0.8.1" async-trait = "0.1.72" prometheus = "0.13.3" diff --git a/src/connector.rs b/src/connector.rs index ccec6c7..8fae8bd 100644 --- a/src/connector.rs +++ b/src/connector.rs @@ -28,14 +28,6 @@ impl Connector for ClickhouseConnector { /// The type of unserializable state type State = ServerState; - fn get_read_regions(_conf: &Self::Configuration) -> std::vec::Vec { - vec![] - } - - fn get_write_regions(_conf: &Self::Configuration) -> std::vec::Vec { - vec![] - } - fn make_empty_configuration() -> Self::RawConfiguration { ServerConfig::default() }