Add support for the Open edX Redwood release #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtmm
force-pushed
the
redwood
branch
2 times, most recently
from
d56828c to
b16a4f9
Compare
fghaas
reviewed
Jul 29, 2024
Changelog.md
Outdated
| ------------------------- | ||
| * [Enhancement] Update requirements to keep in sync with `edx-platfom` | ||
| and support the Open edX Redwood release. | ||
| * [BREAKING CHANGE] Update the import statements for `xblock-utils`. |
There was a problem hiding this comment.
Just checking: can't we make this a non-breaking change by using a try/except block on the import statements and catching the ImportError?
mrtmm
force-pushed
the
redwood
branch
2 times, most recently
from
0eda8bf to
09729ca
Compare
|
We have some tests breaking here (complaining about |
|
Yes, I am still working on this, I reverted to |
mrtmm
force-pushed
the
redwood
branch
3 times, most recently
from
ecceef9 to
9b559ee
Compare
fghaas
approved these changes
Aug 6, 2024
|
Sorry, hold on, I fat-fingered my approval and I can't find a quick way to undo it. |
fghaas
previously approved these changes
Aug 6, 2024
* Update the test matrix to test: - Python 3.8 & Xblock 1.8 (Quince) - Python 3.11,3.12 & Xblock 4.0 (Redwood) * Update requirements to keep in sync with edx-platform * Update import logic to accomodate breaking changes between Xblock>=2 and XBlock<2 versions.
fghaas
reviewed
Aug 6, 2024
fghaas
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.