Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit dependencies #1092

Closed
hasufell opened this issue Jul 1, 2024 · 6 comments
Closed

Audit dependencies #1092

hasufell opened this issue Jul 1, 2024 · 6 comments

Comments

@hasufell
Copy link
Member

hasufell commented Jul 1, 2024

haskell-CI/haskell-ci#655 has sparked my motivation to remove all packages from the respective maintainer from the GHCup deptree.

So let's analyze first and get an overview.

Related: #1089

@jasagredo

@hasufell
Copy link
Member Author

hasufell commented Jul 5, 2024

Affected dependencies (and their maintainers):

  • aeson
    • AdamBergmark
    • BasVanDijk
    • BryanOSullivan
    • HerbertValerioRiedel
    • phadej
    • lyxia
  • cabal-install-parsers
    • phadej
  • cabal-plan
    • HerbertValerioRiedel
    • phadej
  • cryptohash-sha256
    • AustinSeipp
    • HerbertValerioRiedel
    • phadej
  • optics
    • AdamGundry
    • AndresLoeh
    • phadej
    • arybczak
  • regex-posix
    • AndreasAbel
    • HerbertValerioRiedel
    • phadej
    • topos

I think the following dependencies could be swapped out:

  • optics: migrate back to lens (but we use label optics)

The following dependencies will have to be forked or inlined:

  • cabal-install-parsers
  • cabal-plan (could even be dropped)

Unsure about the following dependencies:

  • aeson: we actually need this because yaml uses aeson instances
  • regex-posix: I don't know about any alternative off-hand
  • cryptohash-sha256: there must be an alternative, but I haven't looked hard enough yet

@Kleidukos
Copy link
Member

I wouldn't fret too much about optics, its maintenance is quite trustworthy.

cryptohash-sha256 is not easily replaceable because it's a pure Haskell implementation. If you need trustworthy maintenance, sel is guaranteed to have responsible and responsive maintainers.

@hasufell
Copy link
Member Author

hasufell commented Jul 5, 2024

cryptohash-sha256 is not easily replaceable because it's a pure Haskell implementation

I found two:

They both seem to be Haskell.

@Kleidukos
Copy link
Member

SHA's last commit was 6 years ago, hashing's last commit was from 2 years ago. None of them have CI.

@hasufell
Copy link
Member Author

hasufell commented Jul 5, 2024

SHA's last commit was 6 years ago, hashing's last commit was from 2 years ago. None of them have CI.

SHA was developed by Galois. I don't know how much maintenance does a SHA256 algorithm really need.

hasufell added a commit that referenced this issue Jul 5, 2024
hasufell added a commit that referenced this issue Jul 5, 2024
hasufell added a commit that referenced this issue Jul 5, 2024
hasufell added a commit that referenced this issue Jul 7, 2024
hasufell added a commit that referenced this issue Jul 7, 2024
@hasufell
Copy link
Member Author

mostly done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants