Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow limiting very long-running tests #218

Open
jberryman opened this issue Dec 12, 2019 · 3 comments
Open

Feature request: allow limiting very long-running tests #218

jberryman opened this issue Dec 12, 2019 · 3 comments

Comments

@jberryman
Copy link

I would like a flag that lets me say "never spend more than X seconds on a benchmark; if the time limit is exceeded compile statistics with runs you've done".

I assumed from help that this was what -L did, but I was wrong (I think those docs could be improved too; -L seems to run a benchmark for some fixed amount of time which we wouldn't normally call a "time limit"... I wonder if it was originally meant to do what I thought it did...).

@jberryman
Copy link
Author

maybe dupe of #210

jberryman added a commit to jberryman/graphql-engine that referenced this issue Dec 13, 2019
These aren't suitable e.g. for running in CI since some take far too
long (and an impossibly long-time when running under criterion's normal
bootstrapping sampling regime.

We might try to improve this ourselves:
 haskell/criterion#218

An initial summary analysis will be in hasura#3530.
jberryman added a commit to jberryman/graphql-engine that referenced this issue Dec 13, 2019
These aren't suitable e.g. for running in CI since some take far too
long (and an impossibly long-time when running under criterion's normal
bootstrapping sampling regime.

We might try to improve this ourselves:
 haskell/criterion#218

An initial summary analysis will be in hasura#3530.
jberryman added a commit to jberryman/graphql-engine that referenced this issue Dec 18, 2019
These aren't suitable e.g. for running in CI since some take far too
long (and an impossibly long-time when running under criterion's normal
bootstrapping sampling regime.

We might try to improve this ourselves:
 haskell/criterion#218

An initial summary analysis will be in hasura#3530.
lexi-lambda pushed a commit to jberryman/graphql-engine that referenced this issue Dec 20, 2019
These aren't suitable e.g. for running in CI since some take far too
long (and an impossibly long-time when running under criterion's normal
bootstrapping sampling regime.

We might try to improve this ourselves:
 haskell/criterion#218

An initial summary analysis will be in hasura#3530.
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
These aren't suitable e.g. for running in CI since some take far too
long (and an impossibly long-time when running under criterion's normal
bootstrapping sampling regime.

We might try to improve this ourselves:
 haskell/criterion#218

An initial summary analysis will be in hasura#3530.
@daberg
Copy link

daberg commented Apr 22, 2020

Hello there, I have the same problem as @jberryman. Are there any news about this enhancement? Any possible workarounds? Thanks.

@RyanGlScott
Copy link
Member

I'm not actively working on this, but I would welcome a PR that implemented it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants