Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tar-0.6 #9556

Closed
Bodigrim opened this issue Dec 23, 2023 · 21 comments · Fixed by #9557 or #9597
Closed

Support tar-0.6 #9556

Bodigrim opened this issue Dec 23, 2023 · 21 comments · Fixed by #9557 or #9597

Comments

@Bodigrim
Copy link
Collaborator

cabal-install demands tar < 0.6, prohibiting a recently released https://hackage.haskell.org/package/tar-0.6.0.0.
Cf. commercialhaskell/stackage#7202

@ulysses4ever
Copy link
Collaborator

@Bodigrim thanks for the ping! I'm sure we'd welcome a PR...

@ffaf1
Copy link
Collaborator

ffaf1 commented Dec 23, 2023

We should modify stack @ to ping someone who is active in cabal dev, or even better — if possible — ping cabal as an organisation.

@ffaf1 ffaf1 mentioned this issue Dec 23, 2023
1 task
@Bodigrim
Copy link
Collaborator Author

We should modify stack @ to ping someone who is active in cabal dev, or even better — if possible — ping cabal as an organisation.

AFAIR pinging organisations does not work. I encourage Cabal team

@ffaf1
Copy link
Collaborator

ffaf1 commented Dec 23, 2023

@Bodigrim Is this bit of tar documentation still valid?

Tar.unpack dir . Tar.checkTarbomb expectedDir
               . Tar.read =<< BS.readFile tar

extractTarGzFile dir expected tar =
Tar.unpack dir
. Tar.checkTarbomb expected
. Tar.read
. GZipUtils.maybeDecompress
=<< BS.readFile tar

@Bodigrim
Copy link
Collaborator Author

Good catch! No, you probably need to use something like https://hackage.haskell.org/package/tar-0.6.0.0/docs/Codec-Archive-Tar.html#v:unpackAndCheck

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Dec 24, 2023

Not sure why Stackage would ping us if there's a newer version of our dependency: do they do it, normally? (Sorry, I'm very dark when it comes to Stackage workings.) I thought it's a new Hackage feature, which we probably haven't put to good use. But it will only notify Hackage maintainers (or the mailing list?)? Also, nomeata created a bot for such things I think: would be great to explore that.

@Mikolaj @Kleidukos how about enabling those magic hassle notifications for events like "a newer version of our dependency war published"? If the notification goes to your personal emails, could one of you set up an email filter to forward the notifications to the mailing list?

@Bodigrim
Copy link
Collaborator Author

Not sure why Stackage would ping us if there's a newer version of our dependency: do they do it, normally?

Yes. At the moment (see commercialhaskell/stackage#7202) they ping @23Skidoo, because he was the most active maintainer when cabal-install was added to Stackage. It would be nice to update Stackage config as suggested in #9556 (comment).

Hackage notifications are also useful of course, the more the merrier.

@ulysses4ever
Copy link
Collaborator

@Mikolaj are you fine with being added as the cabal-install owner on Stackage? They will ping you occasionally if something about cabal-install dependencies bounds needs attention.

Does anyone else want to be on the list of people Stackage pings when something is up with cabal-install dependencies? @Kleidukos @ffaf1 @andreabedini @geekosaur and anyone I forget? You can simply thumb-up and I can ship one PR adding everybody.

@geekosaur
Copy link
Collaborator

I feel like I'm still a bit new to this.

@ulysses4ever
Copy link
Collaborator

@geekosaur totally understood, thank you for being honest!

@Mikolaj
Copy link
Member

Mikolaj commented Dec 27, 2023

Yes, absolutely, let's add a lot of people everywhere and set up the Hackage notifications, ideally pointing to https://mail.haskell.org/mailman/listinfo/cabal-devel. I think I'm not getting any Hackage notifications relevant to cabal ATM, though I get some. I will pay attention.

@Bodigrim
Copy link
Collaborator Author

Back to the topic, cabal-install is the last blocker for tar-0.6 in Stackage Nightly snapshot. What's the expected timeline for cabal-install-3.10.3.0? It would be great if support for tar-0.6 was backported.

(The grand design is to update hackage-server as well and test tar-0.6 before releasing more exciting improvements)

@Mikolaj
Copy link
Member

Mikolaj commented Jan 3, 2024

@Bodigrim: I'm sure @Kleidukos has the details.

@Kleidukos
Copy link
Member

We'll be discussing the timeline during this Thursday's cabal meeting. :)

@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Jan 4, 2024

@Kleidukos @Mikolaj whatever the exact timeline, I'd appreciate if you merge #9557 (seems good to go to me) and backport it to Cabal 3.10.3.0.

@ffaf1
Copy link
Collaborator

ffaf1 commented Jan 4, 2024

@Bodigrim we talked about this in today cabal dev meet.

#9557 will be merged (once @gbaz reviews it) and will be backported for 3.10 point release.

@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Jan 7, 2024

Reopening until it's backported to 3.10.

@Bodigrim Bodigrim reopened this Jan 7, 2024
@ffaf1 ffaf1 mentioned this issue Jan 8, 2024
1 task
@ffaf1 ffaf1 linked a pull request Jan 8, 2024 that will close this issue
1 task
@ffaf1
Copy link
Collaborator

ffaf1 commented Jan 8, 2024

Done.

@ffaf1 ffaf1 closed this as completed Jan 8, 2024
@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Jan 8, 2024

Thanks a ton, @ffaf1, for working on this!

@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Feb 8, 2024

@Mikolaj are you fine with being added as the cabal-install owner on Stackage? They will ping you occasionally if something about cabal-install dependencies bounds needs attention.

Does anyone else want to be on the list of people Stackage pings when something is up with cabal-install dependencies? @Kleidukos @ffaf1 @andreabedini @geekosaur and anyone I forget? You can simply thumb-up and I can ship one PR adding everybody.

@ulysses4ever just a reminder that it would be great to act on this: commercialhaskell/stackage#7309 still pings @23Skidoo instead of anyone relevant to Cabal development nowadays.

@ulysses4ever
Copy link
Collaborator

Thank you for the ping. I secretly hoped that someone else would pick it up :-) commercialhaskell/stackage#7311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants