-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build without warnings? #1681
Comments
|
Sure, I would merge PRs that fix warnings. I would prefer them to be submitted one-by-one such that each PR only fixes one type of error. Because I think there could be differing opinions on how to fix some of them. Looking at #1564, it is a bit hard to rebase, and if it had been done in the style I mention, parts of it would probably have been merged already. I think it would make sense to start with the |
Hello! I've created a PR #1710 that fixes the warnings related to the */Type stuff. |
I cloned this repo and did a
cabal build all --enable-tests --enable-benchmarks
and saw lots of warnings. Some warning had previously been fixed #313. Can we build without warnings? Are pull requests that fix warnings welcome?The text was updated successfully, but these errors were encountered: