Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when the user tried to do things that aren't supported #20

Open
stianlagstad opened this issue Jul 2, 2018 · 0 comments

Comments

@stianlagstad
Copy link

Hi!

Thank you for this library. It would be nice if things that aren't yet implemented could throw an exception stating that they are not yet implemented.

An example: When I try to fetch a log object from a v1.4 WITSML server, then after getting the data successfully on this line (https://github.com/hashmapinc/witsml-client/blob/dev/src/main/java/com/hashmapinc/tempus/witsml/client/Client.java#L296), no parsing is done because convertVersion (https://github.com/hashmapinc/witsml-client/blob/dev/src/main/java/com/hashmapinc/tempus/witsml/client/Client.java#L726) does not support 1.4. Rather I end up on this line (https://github.com/hashmapinc/witsml-client/blob/dev/src/main/java/com/hashmapinc/tempus/witsml/client/Client.java#L298) and am returned null. It would be much better for me as a user to be notified of the fact that this is not yet supported. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant