Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Hashdard should use jsx double quotes #4

Open
duranmla opened this issue Feb 17, 2017 · 5 comments
Open

Hashdard should use jsx double quotes #4

duranmla opened this issue Feb 17, 2017 · 5 comments

Comments

@duranmla
Copy link

duranmla commented Feb 17, 2017

The base eslint has jsx double quotes by default, but the standard-jsx doesn't

hashdard_eslintrc_json_at_master_ _hashlabs_hashdard

We need to overwrite that rule of standard-jsx to make it work as expected

eslint-config-standard-jsx_eslintrc_json_at_1d24e6cfb18b58fc1300a48b18b16873b3697692_ _feross_eslint-config-standard-jsx

@carlows
Copy link
Contributor

carlows commented Feb 17, 2017

@duranmla can you explain what issue are you having here?

That rule is being overwritten here: https://github.com/hashlabs/eslint-config-hashdard/blob/master/eslintrc.json#L17

If I remember correctly that PR fixed this issue, isn't it working for you? Did you update hashdard to version 1.0.3?

@duranmla
Copy link
Author

Yes @carlows is the only rule I am having troubles with. It happens with the cli command and as expected with the integration with atom.

1__hashlabs_alexis____hashlabs_internal_simian-ci_client_src_js__zsh_

@duranmla
Copy link
Author

@carlows @orlando this is working for you guys?

@orlando
Copy link
Member

orlando commented Mar 16, 2017

@duranmla no idea, I haven't written JavaScript lately

@carlows
Copy link
Contributor

carlows commented Mar 16, 2017

@duranmla I just bootstrapped an app with create-react-app and for a component like this:

import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';

class App extends Component {
  render() {
    return (
      <div className='App'>
        <div className="App-header">
          <img src={ logo } className="App-logo" alt="logo" />
          <h2>Welcome to React</h2>
        </div>
        <p className="App-intro">
          To get started, edit <code>src/App.js</code> and save to reload.
        </p>
      </div>
    );
  }
}

export default App;

This is what I get from hashdard:

/Users/hashlabs/Documents/CarlosProjects/test-react/src/App.js:8:22: Unexpected usage of singlequote.

So yeah, this is working for me, it expects double quotes on JSX tags.

My versions are:

  • hashdard v1.0.4
  • npm v4.4.1

And I'm running hashdard from the cli.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants